Fix bug of connection event of gamepad at startup #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memoryruins
added
the
A-Input
simpuid
force-pushed
the
gamepad_small_improvement
branch
from
47d5b57
to
11c09a8
Compare
Haha oops. Thanks for catching this :) |
cart
reviewed
Oct 28, 2020
examples/input/gamepad_input.rs
Outdated
| use bevy_input::gamepad::{Gamepad, GamepadButton, GamepadEvent, GamepadEventType}; | ||
| use bevy_utils::HashSet; | ||
|
|
||
| fn main() { | ||
| App::build() | ||
| .add_default_plugins() | ||
| .init_resource::<GamepadLobby>() | ||
| .add_startup_system(connection_system.system()) | ||
| .add_startup_system_to_stage(POST_STARTUP, connection_system.system()) |
There was a problem hiding this comment.
I'm assuming you're adding this duplicate system here in case gamepad_system runs before connection system?
Could we just have a single add_system_to_stage(PRE_UPDATE, connection_system.system()) instead?
There was a problem hiding this comment.
.add_system_to_stage(stage::PRE_UPDATE, connection_system.system()) works fine (tested it too)
simpuid
force-pushed
the
gamepad_small_improvement
branch
from
11c09a8
to
ae88776
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit removes the floating point equality comparison by modifying the filter function. Now filter function outputs
Option<f32>instead off32and output isNonewhen no change is required.Second commit fixes the bug which makes it impossible to detect already connected gamepads at game startup. If you plug the gamepad first and then launches the game, connection event wouldn't occur. Removal of this code causes this bug.
To detect already connected gamepads' connection events at startup, a system must query for events at
POST_STARTUPstage becausebevy_gilrsgenerates raw events atPRE_STARTUPstage andbevy_inputgenerates filtered events atSTARTUPstage (it must execute afterbevy_gilrssystem).